Le jeton de rafraîchissement est une chaîne opaque de 256 bits, jamais un JWT. Il doit être révocable, donc sa ligne en base existe de toute façon, et le JWT n'ajouterait qu'un second chemin de signature. Surtout, la séparation d'avec le jeton d'accès devient structurelle : un JWT ne figure dans aucune ligne, une chaîne opaque échoue au décodage. La confusion refresh-vers-accès, qui transforme une fenêtre de 15 minutes en fenêtre de 7 jours, est impossible même si quelqu'un oublie le test. Seule l'empreinte SHA-256 est stockée. Pas d'Argon2 : l'entrée fait 256 bits de CSPRNG, aucun dictionnaire ne l'atteint, et une KDF coûterait 17 ms à chaque rafraîchissement. La rotation ne protège de rien par elle-même : elle rend la réutilisation détectable, et c'est la détection qui termine le vol. Un jeton déjà tourné révoque donc toute sa famille et laisse une trace dans `audit_log` ; un jeton expiré, lui, ne révoque rien, ce n'est pas une preuve de compromission. Les deux cas ont leur test. La revendication est une seule instruction SQL avec RETURNING. Un SELECT puis un UPDATE laisseraient une fenêtre où deux onglets réussissent la même rotation ; le test d'intégration le prouve, ce qui est indémontrable sur un double. `expires_at` est absolu et hérité du prédécesseur : s'il glissait, la promesse de sept jours serait fictive. Corrige au passage un défaut trouvé par un test : une `HTTPException` construit sa propre réponse, donc l'effacement du cookie posé sur la `Response` injectée était perdu. Un navigateur gardait un cookie mort après une détection de réutilisation.
441 lines
15 KiB
Python
441 lines
15 KiB
Python
from collections.abc import Mapping
|
|
from dataclasses import dataclass, field
|
|
from datetime import UTC, datetime, timedelta
|
|
from typing import Any
|
|
from uuid import UUID, uuid4
|
|
|
|
import pytest
|
|
|
|
from app.core.principal import Principal
|
|
from app.core.roles import AccountKind, Role
|
|
from app.core.security import (
|
|
TokenPolicy,
|
|
decode_access_token,
|
|
fingerprint_refresh,
|
|
)
|
|
from app.models.login_attempt import LoginOutcome
|
|
from app.models.refresh_token import RevocationReason
|
|
from app.repositories.login_attempt import FailureCounts
|
|
from app.repositories.refresh_token import ClaimedToken
|
|
from app.services.auth import (
|
|
AuthService,
|
|
InvalidCredentialsError,
|
|
LoginPolicy,
|
|
RateLimitedError,
|
|
SessionRejectedError,
|
|
)
|
|
|
|
POLITIQUE_JETON = TokenPolicy(
|
|
secret="un-secret-de-test-de-plus-de-trente-deux-caracteres",
|
|
issuer="enervision-api",
|
|
audience="enervision-web",
|
|
access_ttl=timedelta(minutes=15),
|
|
)
|
|
POLITIQUE_CONNEXION = LoginPolicy(
|
|
window_seconds=900,
|
|
max_failures_per_identifier_and_ip=5,
|
|
max_failures_per_ip=20,
|
|
max_failures_per_identifier=50,
|
|
)
|
|
|
|
|
|
@dataclass
|
|
class FauxCompte:
|
|
id: UUID = field(default_factory=uuid4)
|
|
email: str = "operateur@enervision.fr"
|
|
password_hash: str = "$argon2id$factice"
|
|
role: str = "operateur"
|
|
kind: str = "human"
|
|
is_active: bool = True
|
|
must_change_password: bool = False
|
|
credentials_changed_at: datetime = field(default_factory=lambda: datetime.now(UTC))
|
|
|
|
|
|
class FauxDepotComptes:
|
|
def __init__(self, compte: FauxCompte | None) -> None:
|
|
self.compte = compte
|
|
self.rehachages = 0
|
|
self.connexions_datees = 0
|
|
|
|
async def get_by_email(self, email: str) -> FauxCompte | None:
|
|
return self.compte
|
|
|
|
async def get_by_id(self, user_id: UUID) -> FauxCompte | None:
|
|
return self.compte
|
|
|
|
async def rehash_password(self, user_id: UUID, password_hash: str) -> None:
|
|
self.rehachages += 1
|
|
|
|
async def touch_last_login(self, user_id: UUID) -> None:
|
|
self.connexions_datees += 1
|
|
|
|
|
|
class FauxDepotTentatives:
|
|
def __init__(self, compteurs: FailureCounts | None = None) -> None:
|
|
self.compteurs = compteurs or FailureCounts(0, 0, 0)
|
|
self.enregistrees: list[str] = []
|
|
|
|
async def count_recent_failures(self, **_: object) -> FailureCounts:
|
|
return self.compteurs
|
|
|
|
async def record(self, *, outcome: object, **_: object) -> None:
|
|
self.enregistrees.append(str(outcome))
|
|
|
|
|
|
class FauxDepotAudit:
|
|
def __init__(self) -> None:
|
|
self.lignes: list[tuple[str, Mapping[str, Any] | None]] = []
|
|
|
|
async def record(self, *, action: object, detail: Any = None, **_: object) -> None:
|
|
self.lignes.append((str(action), detail))
|
|
|
|
|
|
@dataclass
|
|
class FauxJeton:
|
|
id: UUID = field(default_factory=uuid4)
|
|
family_id: UUID = field(default_factory=uuid4)
|
|
user_id: UUID = field(default_factory=uuid4)
|
|
expires_at: datetime = field(default_factory=lambda: datetime.now(UTC) + timedelta(days=7))
|
|
rotated_at: datetime | None = None
|
|
revoked_at: datetime | None = None
|
|
|
|
|
|
class FauxDepotJetons:
|
|
def __init__(
|
|
self, revendique: ClaimedToken | None = None, connu: FauxJeton | None = None
|
|
) -> None:
|
|
self.revendique = revendique
|
|
self.connu = connu
|
|
self.crees: list[UUID] = []
|
|
self.familles_revoquees: list[tuple[UUID, str]] = []
|
|
self.revocations_par_compte: list[tuple[UUID, str]] = []
|
|
self.liaisons: list[tuple[UUID, UUID]] = []
|
|
|
|
async def create(self, *, user_id: UUID, family_id: UUID, **_: object) -> FauxJeton:
|
|
jeton = FauxJeton(user_id=user_id, family_id=family_id)
|
|
self.crees.append(jeton.id)
|
|
return jeton
|
|
|
|
async def claim_for_rotation(self, token_hash: bytes) -> ClaimedToken | None:
|
|
return self.revendique
|
|
|
|
async def inspect(self, token_hash: bytes) -> FauxJeton | None:
|
|
return self.connu
|
|
|
|
async def link_replacement(self, ancien_id: UUID, nouveau_id: UUID) -> None:
|
|
self.liaisons.append((ancien_id, nouveau_id))
|
|
|
|
async def revoke_family(self, family_id: UUID, reason: RevocationReason) -> int:
|
|
self.familles_revoquees.append((family_id, reason.value))
|
|
return 2
|
|
|
|
async def revoke_all_for_user(self, user_id: UUID, reason: RevocationReason) -> int:
|
|
self.revocations_par_compte.append((user_id, reason.value))
|
|
return 3
|
|
|
|
|
|
class FauxHacheur:
|
|
def __init__(self, *, accepte: bool = True, rehachage_requis: bool = False) -> None:
|
|
self.verifications = 0
|
|
self.hachages = 0
|
|
self._accepte = accepte
|
|
self._rehachage_requis = rehachage_requis
|
|
|
|
async def hash(self, password: str) -> str:
|
|
self.hachages += 1
|
|
return "$argon2id$nouvelle"
|
|
|
|
async def verify(self, stored: str, password: str) -> bool:
|
|
self.verifications += 1
|
|
return self._accepte
|
|
|
|
async def verify_dummy(self) -> None:
|
|
self.verifications += 1
|
|
|
|
def needs_rehash(self, stored: str) -> bool:
|
|
return self._rehachage_requis
|
|
|
|
|
|
class FausseTransaction:
|
|
def __init__(self) -> None:
|
|
self.validations = 0
|
|
|
|
async def commit(self) -> None:
|
|
self.validations += 1
|
|
|
|
|
|
@dataclass
|
|
class Attirail:
|
|
service: AuthService
|
|
comptes: FauxDepotComptes
|
|
tentatives: FauxDepotTentatives
|
|
jetons: FauxDepotJetons
|
|
audit: FauxDepotAudit
|
|
hacheur: FauxHacheur
|
|
|
|
|
|
def fabrique_service(
|
|
*,
|
|
compte: FauxCompte | None = None,
|
|
compteurs: FailureCounts | None = None,
|
|
hacheur: FauxHacheur | None = None,
|
|
jetons: FauxDepotJetons | None = None,
|
|
) -> Attirail:
|
|
comptes = FauxDepotComptes(compte)
|
|
tentatives = FauxDepotTentatives(compteurs)
|
|
depot_jetons = jetons or FauxDepotJetons()
|
|
audit = FauxDepotAudit()
|
|
hacheur = hacheur or FauxHacheur()
|
|
service = AuthService(
|
|
users=comptes, # type: ignore[arg-type]
|
|
attempts=tentatives, # type: ignore[arg-type]
|
|
refresh_tokens=depot_jetons, # type: ignore[arg-type]
|
|
audit=audit, # type: ignore[arg-type]
|
|
hasher=hacheur, # type: ignore[arg-type]
|
|
transaction=FausseTransaction(),
|
|
token_policy=POLITIQUE_JETON,
|
|
login_policy=POLITIQUE_CONNEXION,
|
|
refresh_ttl=timedelta(days=7),
|
|
)
|
|
return Attirail(service, comptes, tentatives, depot_jetons, audit, hacheur)
|
|
|
|
|
|
async def connecte(service: AuthService, mot_de_passe: str = "un-mot-de-passe-valide") -> object:
|
|
return await service.authenticate(
|
|
email="operateur@enervision.fr",
|
|
password=mot_de_passe,
|
|
client_ip="203.0.113.10",
|
|
user_agent="pytest",
|
|
)
|
|
|
|
|
|
async def rafraichit(service: AuthService, secret: str = "un-secret-opaque") -> object:
|
|
return await service.refresh(secret=secret, client_ip="203.0.113.10", user_agent="pytest")
|
|
|
|
|
|
async def test_authenticate_returns_a_readable_access_token_when_credentials_match() -> None:
|
|
compte = FauxCompte()
|
|
attirail = fabrique_service(compte=compte)
|
|
|
|
session = await connecte(attirail.service)
|
|
|
|
claims = decode_access_token(POLITIQUE_JETON, session.access_token) # type: ignore[attr-defined]
|
|
assert claims.subject == compte.id
|
|
assert claims.role == "operateur"
|
|
assert attirail.tentatives.enregistrees == [LoginOutcome.SUCCES.value]
|
|
assert attirail.comptes.connexions_datees == 1
|
|
|
|
|
|
async def test_authenticate_opens_one_refresh_family_per_login() -> None:
|
|
attirail = fabrique_service(compte=FauxCompte())
|
|
|
|
session = await connecte(attirail.service)
|
|
|
|
assert len(attirail.jetons.crees) == 1
|
|
assert session.refresh_secret # type: ignore[attr-defined]
|
|
|
|
|
|
async def test_authenticate_verifies_a_decoy_digest_when_the_email_is_unknown() -> None:
|
|
attirail = fabrique_service(compte=None)
|
|
|
|
with pytest.raises(InvalidCredentialsError):
|
|
await connecte(attirail.service)
|
|
|
|
assert attirail.hacheur.verifications == 1
|
|
assert attirail.tentatives.enregistrees == [LoginOutcome.IDENTIFIANTS_INVALIDES.value]
|
|
|
|
|
|
async def test_authenticate_skips_hashing_entirely_when_the_rate_limit_is_reached() -> None:
|
|
compteurs = FailureCounts(per_identifier_and_ip=5, per_ip=5, per_identifier=5)
|
|
attirail = fabrique_service(compte=FauxCompte(), compteurs=compteurs)
|
|
|
|
with pytest.raises(RateLimitedError):
|
|
await connecte(attirail.service)
|
|
|
|
assert attirail.hacheur.verifications == 0
|
|
assert attirail.hacheur.hachages == 0
|
|
assert attirail.tentatives.enregistrees == [LoginOutcome.LIMITE.value]
|
|
assert attirail.audit.lignes == []
|
|
|
|
|
|
async def test_authenticate_audits_when_the_identifier_threshold_alone_is_reached() -> None:
|
|
compteurs = FailureCounts(per_identifier_and_ip=0, per_ip=0, per_identifier=50)
|
|
attirail = fabrique_service(compte=FauxCompte(), compteurs=compteurs)
|
|
|
|
with pytest.raises(RateLimitedError):
|
|
await connecte(attirail.service)
|
|
|
|
assert len(attirail.audit.lignes) == 1
|
|
assert "identifier_throttled" in attirail.audit.lignes[0][0]
|
|
|
|
|
|
async def test_authenticate_rejects_a_wrong_password_with_the_generic_error() -> None:
|
|
attirail = fabrique_service(compte=FauxCompte(), hacheur=FauxHacheur(accepte=False))
|
|
|
|
with pytest.raises(InvalidCredentialsError):
|
|
await connecte(attirail.service)
|
|
|
|
assert attirail.tentatives.enregistrees == [LoginOutcome.IDENTIFIANTS_INVALIDES.value]
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"compte",
|
|
[FauxCompte(is_active=False), FauxCompte(kind="service")],
|
|
ids=["compte_desactive", "compte_de_service"],
|
|
)
|
|
async def test_authenticate_rejects_unavailable_accounts_after_checking_the_password(
|
|
compte: FauxCompte,
|
|
) -> None:
|
|
attirail = fabrique_service(compte=compte)
|
|
|
|
with pytest.raises(InvalidCredentialsError):
|
|
await connecte(attirail.service)
|
|
|
|
assert attirail.hacheur.verifications == 1
|
|
assert attirail.tentatives.enregistrees == [LoginOutcome.COMPTE_INDISPONIBLE.value]
|
|
|
|
|
|
async def test_authenticate_rehashes_the_password_when_the_parameters_changed() -> None:
|
|
attirail = fabrique_service(compte=FauxCompte(), hacheur=FauxHacheur(rehachage_requis=True))
|
|
|
|
await connecte(attirail.service)
|
|
|
|
assert attirail.comptes.rehachages == 1
|
|
|
|
|
|
async def test_authenticate_leaves_the_digest_alone_when_the_parameters_match() -> None:
|
|
attirail = fabrique_service(compte=FauxCompte())
|
|
|
|
await connecte(attirail.service)
|
|
|
|
assert attirail.comptes.rehachages == 0
|
|
|
|
|
|
async def test_refresh_rotates_the_token_and_keeps_the_family() -> None:
|
|
compte = FauxCompte()
|
|
revendique = ClaimedToken(
|
|
id=uuid4(),
|
|
family_id=uuid4(),
|
|
user_id=compte.id,
|
|
expires_at=datetime.now(UTC) + timedelta(days=5),
|
|
)
|
|
attirail = fabrique_service(compte=compte, jetons=FauxDepotJetons(revendique=revendique))
|
|
|
|
session = await rafraichit(attirail.service)
|
|
|
|
assert session.refresh_secret # type: ignore[attr-defined]
|
|
assert len(attirail.jetons.crees) == 1
|
|
assert attirail.jetons.liaisons == [(revendique.id, attirail.jetons.crees[0])]
|
|
assert attirail.jetons.familles_revoquees == []
|
|
|
|
|
|
async def test_refresh_inherits_the_absolute_expiry_of_its_predecessor() -> None:
|
|
compte = FauxCompte()
|
|
echeance = datetime.now(UTC) + timedelta(days=2)
|
|
revendique = ClaimedToken(id=uuid4(), family_id=uuid4(), user_id=compte.id, expires_at=echeance)
|
|
attirail = fabrique_service(compte=compte, jetons=FauxDepotJetons(revendique=revendique))
|
|
|
|
await rafraichit(attirail.service)
|
|
|
|
assert revendique.expires_at == echeance
|
|
|
|
|
|
async def test_refresh_rejects_an_unknown_secret_without_touching_any_family() -> None:
|
|
attirail = fabrique_service(compte=FauxCompte(), jetons=FauxDepotJetons())
|
|
|
|
with pytest.raises(SessionRejectedError):
|
|
await rafraichit(attirail.service)
|
|
|
|
assert attirail.jetons.familles_revoquees == []
|
|
assert attirail.audit.lignes == []
|
|
|
|
|
|
async def test_refresh_rejects_an_expired_token_without_revoking_its_family() -> None:
|
|
perime = FauxJeton(expires_at=datetime.now(UTC) - timedelta(minutes=1))
|
|
attirail = fabrique_service(compte=FauxCompte(), jetons=FauxDepotJetons(connu=perime))
|
|
|
|
with pytest.raises(SessionRejectedError):
|
|
await rafraichit(attirail.service)
|
|
|
|
assert attirail.jetons.familles_revoquees == []
|
|
assert attirail.audit.lignes == []
|
|
|
|
|
|
async def test_refresh_revokes_the_whole_family_when_a_rotated_token_comes_back() -> None:
|
|
rejoue = FauxJeton(rotated_at=datetime.now(UTC), revoked_at=datetime.now(UTC))
|
|
attirail = fabrique_service(compte=FauxCompte(), jetons=FauxDepotJetons(connu=rejoue))
|
|
|
|
with pytest.raises(SessionRejectedError):
|
|
await rafraichit(attirail.service)
|
|
|
|
assert attirail.jetons.familles_revoquees == [
|
|
(rejoue.family_id, RevocationReason.REUTILISATION.value)
|
|
]
|
|
assert "refresh_reuse_detected" in attirail.audit.lignes[0][0]
|
|
|
|
|
|
async def test_refresh_revokes_the_family_when_the_account_was_disabled_meanwhile() -> None:
|
|
compte = FauxCompte(is_active=False)
|
|
revendique = ClaimedToken(
|
|
id=uuid4(),
|
|
family_id=uuid4(),
|
|
user_id=compte.id,
|
|
expires_at=datetime.now(UTC) + timedelta(days=5),
|
|
)
|
|
attirail = fabrique_service(compte=compte, jetons=FauxDepotJetons(revendique=revendique))
|
|
|
|
with pytest.raises(SessionRejectedError):
|
|
await rafraichit(attirail.service)
|
|
|
|
assert attirail.jetons.familles_revoquees == [
|
|
(revendique.family_id, RevocationReason.ADMINISTRATION.value)
|
|
]
|
|
|
|
|
|
async def test_logout_revokes_only_the_presented_family() -> None:
|
|
connu = FauxJeton()
|
|
attirail = fabrique_service(compte=FauxCompte(), jetons=FauxDepotJetons(connu=connu))
|
|
|
|
await attirail.service.logout(secret="un-secret-opaque")
|
|
|
|
assert attirail.jetons.familles_revoquees == [
|
|
(connu.family_id, RevocationReason.DECONNEXION.value)
|
|
]
|
|
assert attirail.jetons.revocations_par_compte == []
|
|
|
|
|
|
async def test_logout_stays_silent_when_the_cookie_points_at_nothing() -> None:
|
|
attirail = fabrique_service(compte=FauxCompte(), jetons=FauxDepotJetons())
|
|
|
|
await attirail.service.logout(secret="un-secret-inconnu")
|
|
|
|
assert attirail.jetons.familles_revoquees == []
|
|
|
|
|
|
async def test_logout_all_revokes_every_session_and_leaves_an_audit_trail() -> None:
|
|
compte = FauxCompte()
|
|
attirail = fabrique_service(compte=compte)
|
|
acteur = Principal(
|
|
id=compte.id,
|
|
email=compte.email,
|
|
role=Role.OPERATEUR,
|
|
kind=AccountKind.HUMAIN,
|
|
must_change_password=False,
|
|
)
|
|
|
|
revoquees = await attirail.service.logout_all(acteur)
|
|
|
|
assert revoquees == 3
|
|
assert attirail.jetons.revocations_par_compte == [
|
|
(compte.id, RevocationReason.DECONNEXION.value)
|
|
]
|
|
assert "all_sessions_revoked" in attirail.audit.lignes[0][0]
|
|
|
|
|
|
def test_fingerprint_is_what_the_service_stores_not_the_secret_itself() -> None:
|
|
secret = "un-secret-opaque"
|
|
|
|
empreinte = fingerprint_refresh(secret)
|
|
|
|
assert secret.encode() not in empreinte
|